Skip to content

PERF: Styler.tooltips #43737

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 25, 2021
Merged

Conversation

attack68
Copy link
Contributor

When tooltips were developed there were no hidden_rows or hidden_columns and no max_rows or max_columns.

This adds some benchmarks and a minimal change to improve performance. Scope to do a bit better here in future also.

       before           after         ratio
     [cd13e3a4]       [7766f055]
     <master>         <styler_tooltips_perf>
-        52.5±2ms       47.4±0.7ms     0.90  io.style.Render.time_apply_format_hide_render(24, 120)
-       196±0.6ms        173±0.9ms     0.88  io.style.Render.time_tooltips_render(36, 120)
-        78.0±2ms       67.0±0.4ms     0.86  io.style.Render.time_tooltips_render(12, 120)
-         140±2ms        120±0.3ms     0.85  io.style.Render.time_tooltips_render(24, 120)

SOME BENCHMARKS HAVE CHANGED SIGNIFICANTLY.
PERFORMANCE INCREASED.

@jreback jreback added Performance Memory or execution speed performance Styler conditional formatting using DataFrame.style labels Sep 25, 2021
@jreback jreback added this to the 1.4 milestone Sep 25, 2021
@jreback jreback merged commit 8a61d30 into pandas-dev:master Sep 25, 2021
@jreback
Copy link
Contributor

jreback commented Sep 25, 2021

thanks @attack68

@attack68 attack68 deleted the styler_tooltips_perf branch September 25, 2021 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Performance Memory or execution speed performance Styler conditional formatting using DataFrame.style
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants