-
-
Notifications
You must be signed in to change notification settings - Fork 18.5k
BUG: groupby mean fails for complex #43756
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 5 commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
f62f55b
BUG: groupby mean fails for complex
debnathshoham 1457083
whatsnew
debnathshoham 33f499f
added groupby.sum test for complex
debnathshoham b5d9a54
renamed new fused dtype
debnathshoham 6da8470
Merge branch 'master' into gh43701
debnathshoham e306644
Merge branch 'master' into gh43701
debnathshoham 416dd69
added tests that raise for complex
debnathshoham c24a98d
Merge branch 'master' into gh43701
debnathshoham eef4ed9
Merge branch 'master' into gh43701
debnathshoham File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -1301,3 +1301,19 @@ def test_group_mean_datetime64_nat(input_data, expected_output): | |
|
||
result = data.groupby([0, 0, 0]).mean() | ||
tm.assert_series_equal(result, expected) | ||
|
||
|
||
def test_groupby_mean_complex(): | ||
mzeitlin11 marked this conversation as resolved.
Show resolved
Hide resolved
|
||
# GH#43701 | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. can parmaetirze this test instead. also can you add the failing ones in another test, eg.. test_groupby_op_complex_error (e.g. min, max, etc, e.g the non-working ones) |
||
data = Series(np.arange(20).reshape(10, 2).dot([1, 2j])) | ||
result = data.groupby(data.index % 2).mean() | ||
expected = Series([8 + 18j, 10 + 22j]) | ||
tm.assert_series_equal(result, expected) | ||
|
||
|
||
def test_groupby_sum_complex(): | ||
# GH#43701 | ||
data = Series(np.arange(20).reshape(10, 2).dot([1, 2j])) | ||
result = data.groupby(data.index % 2).sum() | ||
expected = Series([40 + 90j, 50 + 110j]) | ||
tm.assert_series_equal(result, expected) |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.