Skip to content

REGR: RollingGroupby.corr producing incorrect results #43854

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 3, 2021

Conversation

rhshadrach
Copy link
Member

The regression is caused by the groupby paths requiring the data to be sorted by groups.

cc @mroeschke and @simonjayhawkins

@rhshadrach rhshadrach added Bug Groupby Regression Functionality that used to work in a prior pandas version Window rolling, ewma, expanding labels Oct 2, 2021
@rhshadrach rhshadrach added this to the 1.3.4 milestone Oct 2, 2021
@rhshadrach
Copy link
Member Author

docs build failure unrelated:

WARNING: failed to reach any of the inventories with the following issues:
intersphinx inventory 'https://www.statsmodels.org/devel/objects.inv' not fetchable due to <class 'requests.exceptions.ConnectionError'>: HTTPSConnectionPool(host='www.statsmodels.org', port=443): Max retries exceeded with url: /devel/objects.inv (Caused by NewConnectionError('<urllib3.connection.HTTPSConnection object at 0x7fab49a33f70>: Failed to establish a new connection: [Errno -3] Temporary failure in name resolution'))
building [mo]: targets for 0 po files that are out of date
building [html]: targets for 158 source files that are out of date
updating environment: [new config] 2550 added, 0 changed, 0 removed
reading sources... [ 4%] development/code_style .. reference/api/pandas.DataFrame.dot

Copy link
Member

@mroeschke mroeschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! LGTM

@jreback
Copy link
Contributor

jreback commented Oct 3, 2021

there is a fail on the warnings built but i think already fixed on master

thanks @rhshadrach

@jreback jreback merged commit 54ceeff into pandas-dev:master Oct 3, 2021
@jreback
Copy link
Contributor

jreback commented Oct 3, 2021

@meeseeksdev backport 1.3.x

@lumberbot-app
Copy link

lumberbot-app bot commented Oct 3, 2021

Something went wrong ... Please have a look at my logs.

@rhshadrach rhshadrach deleted the rolling_regr branch October 3, 2021 13:53
phofl pushed a commit that referenced this pull request Oct 3, 2021
gasparitiago pushed a commit to gasparitiago/pandas that referenced this pull request Oct 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Groupby Regression Functionality that used to work in a prior pandas version Window rolling, ewma, expanding
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: RollingGroupby.corr() producing incorrect results
3 participants