-
-
Notifications
You must be signed in to change notification settings - Fork 18.5k
REGR: RollingGroupby.corr producing incorrect results #43854
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
docs build failure unrelated:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! LGTM
there is a fail on the warnings built but i think already fixed on master thanks @rhshadrach |
@meeseeksdev backport 1.3.x |
Something went wrong ... Please have a look at my logs. |
…ults (#43859) Co-authored-by: Richard Shadrach <[email protected]>
The regression is caused by the groupby paths requiring the data to be sorted by groups.
cc @mroeschke and @simonjayhawkins