Skip to content

CLN/TST: Remove redundant/unnecessary windows/moments tests #44239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Oct 30, 2021

Conversation

mroeschke
Copy link
Member

  • Avoids running similar def test_* checks more than once
  • Thins out the consistency_data pytest fixture to test data with certain properties only once (constant values, all nans, monotonically increasing, etc)

@mroeschke mroeschke added Testing pandas testing functions or related to the test suite Window rolling, ewma, expanding labels Oct 30, 2021
@jreback jreback added this to the 1.4 milestone Oct 30, 2021
@jreback jreback merged commit 6312a8f into pandas-dev:master Oct 30, 2021
@jreback
Copy link
Contributor

jreback commented Oct 30, 2021

great

@mroeschke mroeschke deleted the clean/rolling_consistency_tests branch October 30, 2021 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Testing pandas testing functions or related to the test suite Window rolling, ewma, expanding
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI: revert disable of windows window/moments tests
2 participants