ENH: Add numba engine to rolling/expanding.std/var #44461
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
mroeschke
commented
Nov 15, 2021
mroeschke
commented
- tests added / passed
- Ensure all linting tests pass, see here for how to run them
- whatsnew entry
|
Failure due to codecov not being able to tell the numba decorated function is inherently tested. |
jreback
requested changes
Nov 25, 2021
| @@ -212,7 +212,8 @@ Other enhancements | |||
| - :meth:`.GroupBy.mean` now supports `Numba <http://numba.pydata.org/>`_ execution with the ``engine`` keyword (:issue:`43731`) | |||
| - :meth:`Timestamp.isoformat`, now handles the ``timespec`` argument from the base :class:``datetime`` class (:issue:`26131`) | |||
| - :meth:`NaT.to_numpy` ``dtype`` argument is now respected, so ``np.timedelta64`` can be returned (:issue:`44460`) | |||
| - | |||
| - :meth:`.Rolling.var`, :meth:`.Expanding.var`, :meth:`.Rolling.std`, :meth:`.Expanding.std` now support `Numba <http://numba.pydata.org/>`_ execution with the ``engine`` keyword (:issue:`44461`) | |||
There was a problem hiding this comment.
at some point should group these doc-string changes together (maybe into a separate section ok too but not requried)
There was a problem hiding this comment.
Yeah once I add median I can group these better
| nv.validate_window_func("std", args, kwargs) | ||
| if maybe_use_numba(engine): | ||
| if self.method == "table": | ||
| raise NotImplementedError("std not supported with method='table'") |
There was a problem hiding this comment.
| nv.validate_window_func("var", args, kwargs) | ||
| if maybe_use_numba(engine): | ||
| if self.method == "table": | ||
| raise NotImplementedError("var not supported with method='table'") |
There was a problem hiding this comment.
It's this flaky test |
jreback
approved these changes
Nov 26, 2021
|
thanks @mroeschke |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.