TYP: changed variable new_pd_index to final_pd_index #44500
Conversation
|
Hello @prithvijitguha! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found: There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2021-11-17 15:43:05 UTC |
pandas/io/pytables.py
Outdated
| # error: Incompatible types in assignment (expression has type | ||
| # "Union[ndarray, DatetimeIndex]", variable has type "Index") |
There was a problem hiding this comment.
Thakns @prithvijitguha - this comment can be removed as well, right?
There was a problem hiding this comment.
Yes. its from the previous "#type ignore". Do I need to fix that and commit it? Thanks for reviewing @MarcoGorelli
There was a problem hiding this comment.
@MarcoGorelli Thank you, just removed the comment and removed any remaining trailing whitespace. Should pass now!
|
Hi @MarcoGorelli Thanks for the review. Its failing one test which is similar to the test failed in another similar pull request #44231 |
|
It's unrelated, don't worry about it This looks good to me, I'm just not sure about the |
|
thanks @prithvijitguha |
xref #37715
Changed variable new_pd_index to final_pd_index in line 2099
Handled mypy type ignore[assignment] error in pandas/io/pytables.py in line 2099