ENH: implement tm.shares_memory #44747
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbrockmendel
commented
Dec 5, 2021
| return shares_memory(left.sp_values, right) | ||
|
|
||
| if isinstance(left, ExtensionArray) and left.dtype == "string[pyarrow]": | ||
| # https://github.com/pandas-dev/pandas/pull/43930#discussion_r736862669 |
There was a problem hiding this comment.
@jorisvandenbossche can you confirm that this is the right logic to use for ArrowStringArray?
There was a problem hiding this comment.
Yes, but this will only be correct if both left and right only have a single chunk, which is not guaranteed to be the case (although probably will be the case in all tests where this is being used). Maybe adding an assert to guarantee this would be good
|
Meant to implement tests before merging; will do so in follow-up(s) |
|
I think this is causing mypy to complain on master: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
xref #44152
Dedicated implementation based on https://github.com/pandas-dev/pandas/pull/43930/files#diff-6676eb1e10942179c11b3ef5a8a59d835a05873934580a52139117ebd1f2d7c3R236