Skip to content

REF: use dispatch_reduction_ufunc in PandasArray.__array_ufunc__ #44820

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 14, 2021
Merged

REF: use dispatch_reduction_ufunc in PandasArray.__array_ufunc__ #44820

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a49ca2e
REF: use dispatch_reduction_ufunc in PandasArray.__array_ufunc__
jbrockmendel Dec 8, 2021
60c6e46
Merge branch 'master' into ref-array_ufunc
jbrockmendel Dec 10, 2021
1de75f2
Merge branch 'master' into ref-array_ufunc
jbrockmendel Dec 12, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 13 additions & 12 deletions pandas/core/arrays/numpy_.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@
from pandas.core.dtypes.missing import isna

from pandas.core import (
arraylike,
nanops,
ops,
)
Expand Down Expand Up @@ -144,6 +145,14 @@ def __array_ufunc__(self, ufunc: np.ufunc, method: str, *inputs, **kwargs):
if result is not NotImplemented:
return result

if method == "reduce":
result = arraylike.dispatch_reduction_ufunc(
self, ufunc, method, *inputs, **kwargs
)
if result is not NotImplemented:
# e.g. tests.series.test_ufunc.TestNumpyReductions
return result

# Defer to the implementation of the ufunc on unwrapped values.
inputs = tuple(x._ndarray if isinstance(x, PandasArray) else x for x in inputs)
if out:
Expand All @@ -153,13 +162,8 @@ def __array_ufunc__(self, ufunc: np.ufunc, method: str, *inputs, **kwargs):
result = getattr(ufunc, method)(*inputs, **kwargs)

if ufunc.nout > 1:
# multiple return values
if not lib.is_scalar(result[0]):
# re-box array-like results
return tuple(type(self)(x) for x in result)
else:
# but not scalar reductions
return result
# multiple return values; re-box array-like results
return tuple(type(self)(x) for x in result)
elif method == "at":
# no return value
return None
Expand All @@ -171,11 +175,8 @@ def __array_ufunc__(self, ufunc: np.ufunc, method: str, *inputs, **kwargs):
# e.g. test_np_max_nested_tuples
return result
else:
# one return value
if not lib.is_scalar(result):
# re-box array-like results, but not scalar reductions
result = type(self)(result)
return result
# one return value; re-box array-like results
return type(self)(result)

# ------------------------------------------------------------------------
# Pandas ExtensionArray Interface
Expand Down