TST: Split/parameterize test_split_partition.py #44876
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
mroeschke
commented
Dec 14, 2021
mroeschke
commented
- tests added / passed
- Ensure all linting tests pass, see here for how to run them
mroeschke
added
the
Testing
jreback
requested changes
Dec 14, 2021
| tm.assert_series_equal(result, expected) | ||
|
|
||
|
|
||
| def test_rsplit(any_string_dtype): | ||
| values = Series(["a_b_c", "c_d_e", np.nan, "f_g_h"], dtype=any_string_dtype) |
There was a problem hiding this comment.
don't you need these cases?
There was a problem hiding this comment.
Parameterized now in test_split and test_split_more_than_one_char,
| # setting max number of splits, make sure it's from reverse | ||
| values = Series(["a_b_c", "c_d_e", np.nan, "f_g_h"], dtype=any_string_dtype) | ||
| result = values.str.rsplit("_", n=1) | ||
| exp = Series([["a_b", "c"], ["c_d", "e"], np.nan, ["f_g", "h"]]) | ||
| tm.assert_series_equal(result, exp) | ||
|
|
||
|
|
||
| def test_rsplit_object_mixed(): |
There was a problem hiding this comment.
Parameterized now in test_split_object_mixed
jreback
approved these changes
Dec 15, 2021
Comment on lines
+437
to
+440
| def test_partition_series_more_than_one_char(method, exp): | ||
| # https://github.com/pandas-dev/pandas/issues/23558 | ||
|
|
||
| s = Series(["a_b_c", "c_d_e", np.nan, "f_g_h", None], dtype=any_string_dtype) | ||
|
|
||
| result = s.str.partition("_", expand=False) | ||
| expected = Series( | ||
| [("a", "_", "b_c"), ("c", "_", "d_e"), np.nan, ("f", "_", "g_h"), None] | ||
| ) | ||
| # more than one char | ||
| s = Series(["a__b__c", "c__d__e", np.nan, "f__g__h", None]) |
There was a problem hiding this comment.
any_string_dtype parameterization?
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.