Skip to content

DOC: MultiIndex.get_level_values mentions implicit type casting if level contains null. #44894

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jan 5, 2022
Merged

DOC: MultiIndex.get_level_values mentions implicit type casting if level contains null. #44894

merged 6 commits into from
Jan 5, 2022

Conversation

isVoid
Copy link
Contributor

@isVoid isVoid commented Dec 15, 2021

phofl
phofl requested changes Dec 15, 2021
View reviewed changes
Copy link
Member

@phofl phofl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you mention that this happens because we convert the level to a regular Index instead of a MultiIndex

@isVoid
Copy link
Contributor Author

isVoid commented Dec 15, 2021

I was hesitant to write "internally MultiIndex is implemented by codes but regular index doesn't", concerning that reveals too much implementation details in the docstring. Let me know if it fits in.

phofl
phofl reviewed Dec 15, 2021
View reviewed changes
@isVoid isVoid requested a review from phofl December 16, 2021 21:23
@jreback
Copy link
Contributor

jreback commented Dec 20, 2021

can you add an example which illustrates this as well.

@isVoid
Copy link
Contributor Author

isVoid commented Dec 29, 2021

Example added. @jreback

jreback
jreback requested changes Dec 30, 2021
View reviewed changes
Copy link
Contributor

@jreback jreback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one comment. ping when ready

@jreback jreback added this to the 1.4 milestone Jan 5, 2022
@jreback jreback merged commit edb9d62 into pandas-dev:master Jan 5, 2022
@jreback
Copy link
Contributor

jreback commented Jan 5, 2022

thanks @isVoid

@meeseeksmachine meeseeksmachine mentioned this pull request Jan 5, 2022
Merged
meeseeksmachine pushed a commit to meeseeksmachine/pandas that referenced this pull request Jan 5, 2022
@isVoid @meeseeksmachine
Backport PR pandas-dev#44894: DOC: MultiIndex.get_level_values ment…
64944bd 
…ions implicit type casting if level contains null.
@jreback
Copy link
Contributor

jreback commented Jan 5, 2022

@meeseeksdev backport 1.4.x

@lumberbot-app
Copy link

lumberbot-app bot commented Jan 5, 2022

Something went wrong ... Please have a look at my logs.

lithomas1 pushed a commit that referenced this pull request Jan 6, 2022
@meeseeksmachine @isVoid
Backport PR #44894: DOC: MultiIndex.get_level_values mentions impli…
686a664 
…cit type casting if level contains null. (#45210)

Co-authored-by: Michael Wang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jreback jreback jreback approved these changes

@phofl phofl Awaiting requested review from phofl

Assignees
No one assigned
Labels
Docs MultiIndex
Projects
None yet
Milestone
1.4
Development

Successfully merging this pull request may close these issues.

BUG: MultiIndex constructed with nulls inconsistent with dtypes and get_level_values
3 participants
@isVoid @jreback @phofl