CLN: tests/window/moments #44961
Merged
CLN: tests/window/moments #44961
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroeschke
added
Testing
pandas/tests/window/moments/test_moments_consistency_expanding.py
Outdated
Show resolved
Hide resolved
|
One comment, otherwise LGTM |
|
BTW just curious, is there a gameplan for the xfails in test_online and test_expanding? |
Hmm those xfails are just not implemented features with associated issues I think. I don't have a timeline for tackling those yet. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reduces a lot of no-op parameterizations by creating more specific fixtures