REF: dispatch Series.rank to EA #45037
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jreback
reviewed
Dec 24, 2021
| pct=pct, | ||
| ) | ||
| else: | ||
| ranks = algos.rank( |
There was a problem hiding this comment.
can you not just do this indiretion in algos?
There was a problem hiding this comment.
i take it back, doing it in algos causes a RecursionError
There was a problem hiding this comment.
kk i see what you did for mode so maybe this ok
jbrockmendel
force-pushed
the
ref-values_for_rank
branch
from
201d29b to
bd3a3a1
Compare
jreback
added
Algos
|
looks ok to me |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test coverage is severely lacking here.
Maybe could implement the general case in terms of argsort? cc @TomAugspurger @jorisvandenbossche