DEPR: Deprecate set and dict as indexers #45052
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jreback
requested changes
Dec 24, 2021
pandas/core/frame.py
Outdated
| @@ -3456,7 +3456,32 @@ def _iter_column_arrays(self) -> Iterator[ArrayLike]: | |||
| for i in range(len(self.columns)): | |||
| yield self._get_column_array(i) | |||
|
|
|||
| def _check_deprecated_indexers(self, key): | |||
There was a problem hiding this comment.
can this be a function in indexing.py or similar?
There was a problem hiding this comment.
Yep done, hadn't had much time on friday and wanted to check at least whether I got every occurrence in the test suite
pandas/core/indexing.py
Outdated
| @@ -942,7 +950,32 @@ def _getitem_nested_tuple(self, tup: tuple): | |||
| def _convert_to_indexer(self, key, axis: int): | |||
| raise AbstractMethodError(self) | |||
|
|
|||
| def _check_deprecated_indexers(self, key): | |||
There was a problem hiding this comment.
same make this a function (and just call it here)
jreback
added
Deprecate
mroeschke
reviewed
Dec 28, 2021
|
Not 100% sure, but wanted to add explicit checks as followups to raise a controlled error. Something we can reuse for the deprecated cases. |
sgtm |
jreback
approved these changes
Dec 29, 2021
|
thanks @phofl |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes DOC: .loc doesn't document that it can take sets or dicts as arguments #42825
tests added / passed
Ensure all linting tests pass, see here for how to run them
whatsnew entry
DataFrame.__setitem__does not work for unhashable objectilocdoes not work for unhashable objects for getitem and setitem