Skip to content

CLN: remove sqlalchemy<14 compat #45410

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jan 19, 2022
Merged

CLN: remove sqlalchemy<14 compat #45410

merged 5 commits into from
Jan 19, 2022

Conversation

fangchenli
Copy link
Member

No description provided.

@jreback jreback added Dependencies Required and optional dependencies IO SQL to_sql, read_sql, read_sql_query labels Jan 17, 2022
mroeschke
mroeschke approved these changes Jan 17, 2022
View reviewed changes
Copy link
Member

@mroeschke mroeschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM pending green

@mroeschke mroeschke added this to the 1.5 milestone Jan 17, 2022
@jreback
Copy link
Contributor

jreback commented Jan 17, 2022

CI is bumped for >= 1.4? and there is a whatsnew note on this?

@fangchenli
Copy link
Member Author

CI is bumped for >= 1.4? and there is a whatsnew note on this?

yes #43191

@jreback jreback merged commit 4ce84de into pandas-dev:main Jan 19, 2022
@jreback
Copy link
Contributor

jreback commented Jan 19, 2022

thanks @fangchenli

@fangchenli fangchenli deleted the clean-sqlalchemy14-compat branch November 18, 2022 02:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mroeschke mroeschke mroeschke approved these changes

Assignees
No one assigned
Labels
Dependencies Required and optional dependencies IO SQL to_sql, read_sql, read_sql_query
Projects
None yet
Milestone
1.5
Development

Successfully merging this pull request may close these issues.
3 participants
@fangchenli @jreback @mroeschke