TYP: groupby, sorting #46133
Merged
TYP: groupby, sorting #46133
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rhshadrach
approved these changes
Feb 24, 2022
| @@ -223,7 +223,9 @@ def is_int64_overflow_possible(shape) -> bool: | |||
| return the_prod >= lib.i8max | |||
|
|
|||
|
|
|||
| def decons_group_index(comp_labels, shape): | |||
| def _decons_group_index( | |||
There was a problem hiding this comment.
Just curious on the rename here - why specifically make this one lead with an underscore?
There was a problem hiding this comment.
this is the only thing that stood out to me as being privatize-able
twoertwein
reviewed
Feb 25, 2022
jreback
added
Groupby
Reshaping
|
can you rebase |
|
Rebased + green |
3 tasks
yehoshuadimarsky
pushed a commit
to yehoshuadimarsky/pandas
that referenced
this pull request
Jul 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.