REF: combine masked_cummin_max, cummin_max #46142
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroeschke
reviewed
Feb 25, 2022
| if iu_64_floating_t is float64_t or iu_64_floating_t is float32_t: | ||
| if uses_mask: | ||
| na_possible = True | ||
| # Will never be used, just to avoid uninitialized warning |
There was a problem hiding this comment.
Could just define na_val = 0 in the cdef above?
|
assume this is neutral or postive on perf? |
neutral |
jbrockmendel
commented
Feb 27, 2022
| if not skipna and na_possible and seen_na[lab, j]: | ||
| out[i, j] = na_val | ||
| if uses_mask: | ||
| mask[i, j] = 1 # FIXME: shouldn't alter inplace |
There was a problem hiding this comment.
follow-up in the works to fix this
yehoshuadimarsky
pushed a commit
to yehoshuadimarsky/pandas
that referenced
this pull request
Jul 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
more closely match pattern we use for other mask-supporting functions in this file