Typ: Fix io stata type ignores #46449
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
twoertwein
reviewed
Mar 22, 2022
FactorizeD
force-pushed
the
typ-fix-io-stata-type-ignores
branch
from
c290976 to
eeb1c48
Compare
twoertwein
reviewed
Mar 22, 2022
twoertwein
reviewed
Mar 22, 2022
FactorizeD
force-pushed
the
typ-fix-io-stata-type-ignores
branch
from
eeb1c48 to
cf220a0
Compare
twoertwein
approved these changes
Mar 22, 2022
There was a problem hiding this comment.
Thank you @FactorizeD, looks good to me! Can you please mark the PR as "ready for review"?
Welcome to pandas!
|
@twoertwein lgtm merge on green. |
|
Thank you @FactorizeD doc failure looks unrelated. |
yehoshuadimarsky
pushed a commit
to yehoshuadimarsky/pandas
that referenced
this pull request
Jul 13, 2022
GH37715 Co-authored-by: Mateusz <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
xref #37715
Hi all, first time contributing, please let me know if all is OK process-wise (e.g. commit message, if it is OK that the changes are not squashed)
Regarding the changed code - I added c_data_large for consistency (c_data_small was required to fix type: ignore), can remove if you think that it is unnecessary