Improve error message for DataFrame.from_dict when wrong orient is provided #47451
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't think any tests are needed for this, since it really is such a small fix. Could be wrong though :/ |
phofl
requested changes
Jun 21, 2022
|
Damn yall really test everything lol. Ok I will fix the failing test, at least now I have a good idea of which test to fix. |
|
I think these failures are unrelated |
|
Ah. Ok I will write new tests then |
KianShah
commented
Jun 22, 2022
datapythonista
changed the title
datapythonista
added
Error Reporting
KianShah
commented
Jun 23, 2022
| @@ -189,3 +184,16 @@ def test_frame_dict_constructor_empty_series(self): | |||
| # it works! | |||
| DataFrame({"foo": s1, "bar": s2, "baz": s3}) | |||
| DataFrame.from_dict({"foo": s1, "baz": s3, "bar": s2}) | |||
|
|
|||
| def test_from_dict_scalars_requires_index(self): | |||
There was a problem hiding this comment.
Note: I moved this function down here, so that all functions that test exception behaviours are grouped together. Not sure if that complies to the guidelines, but it certainly seems better
datapythonista
approved these changes
Jun 24, 2022
phofl
approved these changes
Jun 24, 2022
|
thx @KianShah |
yehoshuadimarsky
pushed a commit
to yehoshuadimarsky/pandas
that referenced
this pull request
Jul 13, 2022
…ovided (pandas-dev#47451) * Fixed error message * Update v1.4.3.rst * Update v1.4.3.rst * Added test case * Added test * Fix rst file * Fix black issues * Fixed error msg and corresponding test * improved changelog * Also fix python docstring for :func:to_dict * Fix failing test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.