Skip to content

DOC: fix typos in "See also" documentation section #47712

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Jul 16, 2022
Merged

DOC: fix typos in "See also" documentation section #47712

merged 7 commits into from
Jul 16, 2022

Conversation

partev
Copy link
Contributor

@partev partev commented Jul 14, 2022

  • closes #xxxx (Replace xxxx with the Github issue number)
  • Tests added and passed if fixing a bug or adding a new feature
  • All code checks passed.
  • Added type annotations to new arguments/methods/functions.
  • Added an entry in the latest doc/source/whatsnew/vX.X.X.rst file if fixing a bug or adding a new feature.

partev added 3 commits July 13, 2022 21:44
@partev
DOC: fix typos in DataFrame.cov() documentation
e008b3a 
fix typos in DataFrame.cov() See also documentation section
@partev
DOC: fix a typo in expanding cummax and cummin
8e66c1e 
DOC: fix a typo in expanding cummax and cummin in See also documentation section.
@partev
DOC: fix a typo in quantile documentation
7183478 
fix a typo in quantile "See also" documentation section
@pep8speaks
Copy link

pep8speaks commented Jul 14, 2022 •
edited
Loading

Hello @partev! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2022-07-16 11:54:24 UTC

MarcoGorelli
MarcoGorelli suggested changes Jul 16, 2022
View reviewed changes
Copy link
Member

@MarcoGorelli MarcoGorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice to have these links fixed, thanks - can you fix up the linting failures please?

@MarcoGorelli MarcoGorelli self-requested a review July 16, 2022 13:20
MarcoGorelli
MarcoGorelli approved these changes Jul 16, 2022
View reviewed changes
Copy link
Member

@MarcoGorelli MarcoGorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, I checked the docs and the links work now

Thanks @partev !

@MarcoGorelli MarcoGorelli added this to the 1.5 milestone Jul 16, 2022
@MarcoGorelli MarcoGorelli merged commit 5eca390 into pandas-dev:main Jul 16, 2022
@partev partev deleted the patch-11 branch July 17, 2022 01:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarcoGorelli MarcoGorelli MarcoGorelli approved these changes

Assignees
No one assigned
Labels
Docs
Projects
None yet
Milestone
1.5
Development

Successfully merging this pull request may close these issues.
3 participants
@partev @pep8speaks @MarcoGorelli