Skip to content

DOC: add pivot_table note to dropna doc #47808

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Aug 1, 2022
Merged

DOC: add pivot_table note to dropna doc #47808

Changes from 4 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
5327fe8
moving edits to pivot_table
Mehgarg Jul 26, 2022
445c7ed
missing punctuation'
Mehgarg Jul 26, 2022
2c65631
trailing whitespace
Mehgarg Jul 28, 2022
43ec8e4
clarifying documentation
Mehgarg Jul 28, 2022
8eea774
formatting
Mehgarg Jul 29, 2022
88a98e5
reverting line
Mehgarg Jul 29, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions pandas/core/frame.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8564,7 +8564,9 @@ def pivot(self, index=None, columns=None, values=None) -> DataFrame:
margins : bool, default False
Add all row / columns (e.g. for subtotal / grand totals).
dropna : bool, default True
Do not include columns whose entries are all NaN.
Do not include columns whose entries are all NaN. If true:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

True refers to Python True value, we usually use it with capital T. Also, please avoid the colon, as it's inconsistent with the rest of the docs, and personally I think make things harder to read in this case.

Other than those small formatting things, I think your description is clear now, thanks for thr update.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

made the changes, thanks for the help.

rows with a NaN value in any column will be omitted before
computing margins.
margins_name : str, default 'All'
Name of the row / column that will contain the totals
when margins is True.
Expand Down Expand Up @@ -10045,7 +10047,7 @@ def merge(
suffixes: Suffixes = ("_x", "_y"),
copy: bool = True,
indicator: bool = False,
validate: str | None = None,
validate: str | None = None,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please revert this?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is pending and making the CI red

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reverted

) -> DataFrame:
from pandas.core.reshape.merge import merge

Expand Down