-
-
Notifications
You must be signed in to change notification settings - Fork 18.5k
WARN: Remove false positive warning for iloc inplaceness #48397
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 9 commits
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
8f7432b
WARN: Remove false positive warning for iloc inplaceness
phofl 9ac855b
Improve check
phofl 2c3920c
Improve check
phofl 8fc58f3
Check for object too
phofl ab1080c
Improve check
phofl 1aa0448
Merge remote-tracking branch 'upstream/main' into warn_iloc_inplace
phofl 40427c4
Fix test
phofl 7240895
Filter warning
phofl a1a824c
Add another filter
phofl 03bc147
Add comment
phofl 44e910d
Add parens
phofl 0d2c2c4
Recheck
phofl 7f04bdc
Only check new values
phofl c4b0780
Add comment
phofl 49da3ce
Check for now warning
phofl 7e4e5e8
Merge remote-tracking branch 'upstream/main' into warn_iloc_inplace
phofl 805ec5d
Refactor
phofl 7762cda
Make test consistent
phofl ead315a
Revert "Make test consistent"
phofl 8a772c7
Fix
phofl b4714ce
Merge remote-tracking branch 'upstream/main' into warn_iloc_inplace
phofl a6de70e
xfail test
phofl File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.