-
-
Notifications
You must be signed in to change notification settings - Fork 18.5k
Fix Excel-specific border styles #48660
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 8 commits
e3f2ea8
1657735
16258a9
6626a97
69d75fa
25ad970
e7d7eb0
d2680ef
ec3e137
fb0f81c
cb8068a
d169d3a
e632719
222cf3a
f7b698c
3e65ce7
db09655
e352a1c
c6e4c5c
d9fad6d
7c9f7d0
a6abe18
eae63aa
e050967
0ae7634
69366ae
ba774f7
97fd1c1
84273e3
b5773f5
8a0f656
b6f6212
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -23,7 +23,8 @@ Fixed regressions | |
|
||
Bug fixes | ||
~~~~~~~~~ | ||
- | ||
- Bug in :class:`CSSToExcelConverter` leading to error when unrecognized ``border-style`` (including ``"hair"``) provided to Excel writers (:issue:`48649`) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I would slightly learn toward moving this to There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I could support either, but to play devil's advocate: pandas never specified that these particular border-styles were supported or unsupported. The closest thing to documentation was this comment block in
I think the error when using I definitely think I'm onboard with removing the color defaulting portion from a v1.5.1 and moving it to a separate PR for v1.6.0 There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
The criteria for whether something should go in a patch or minor version is "did it work before". That is, patch releases should only fix regressions. As this isn't a regression, I'm also +1 on putting this in 1.6.0. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I suggest that if There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Okay given the reduced scope (removing the color defaulting). I would be okay with 1.5.1 |
||
- Bug in :class:`CSSToExcelConverter` where border would not fall back on black when border style or width provided without a color (:issue:`48649`) | ||
tehunter marked this conversation as resolved.
Show resolved
Hide resolved
|
||
- | ||
|
||
.. --------------------------------------------------------------------------- | ||
|
Uh oh!
There was an error while loading. Please reload this page.