BLD: Install anaconda client in a separate step #48755
Conversation
| python-version: '3.8' | ||
|
|
||
| - name: Install anaconda client | ||
| if: ${{ success() && (env.IS_SCHEDULE_DISPATCH == 'true' || env.IS_PUSH == 'true') }} |
There was a problem hiding this comment.
Is env.IS_PUSH different from github.event_name == 'push'?
There was a problem hiding this comment.
Yeah, it actually only looks for tagged events.
| - name: Build sdist | ||
| run: | | ||
| pip install build | ||
| python -m build --sdist | ||
| - name: Test the sdist | ||
| shell: bash -el {0} |
There was a problem hiding this comment.
Not for this PR, but I think it'd be nice to have this at the beginning for all steps. I think I tried once and had some problems, even if it's supposed to be supported. But maybe worth having a look at some point, as we're using conda environments most of the time.
Co-authored-by: Marc Garcia <[email protected]>
.github/workflows/wheels.yml
Outdated
| python-version: '3.8' | ||
| channels: conda-forge,defaults |
There was a problem hiding this comment.
I had bad experiences in the past with the defaults channel (when mixed with conda-forge), and I've been using conda-forge only. If you've got a reason to have defaults surely fine, but otherwise I'd probably remove it.
|
Going to put this now, so I can see how it runs tonight. |
* BLD: Install anaconda client in a separate step * Apply suggestions from code review Co-authored-by: Marc Garcia <[email protected]> * Update wheels.yml * Update wheels.yml Co-authored-by: Marc Garcia <[email protected]>
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.The uploading wasn't working properly, since conda is unfortunately not added to PATH on Github Actions, it is on Azure Pipelines on the other repo.
I tested on my repo, and it should also work here.