API: preserve reso in Timelta(td64_obj) #48910
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroeschke
added
Timedelta
5 tasks
mroeschke
reviewed
Oct 5, 2022
| raise NotImplementedError | ||
| return _broadcast_floordiv_td64(self.value, other, _floordiv) | ||
| # TODO: could suppress | ||
| # RuntimeWarning: invalid value encountered in floor_divide |
There was a problem hiding this comment.
This would be great (especially if it comes from a pandas routine) so we can turn on -W:::pandas in the future
mroeschke
reviewed
Oct 5, 2022
| @@ -134,7 +134,8 @@ def _calculate_deltas( | |||
| _times = np.asarray( | |||
| times.view(np.int64), dtype=np.float64 # type: ignore[union-attr] | |||
| ) | |||
| _halflife = float(Timedelta(halflife).value) | |||
| # TODO: generalize to non-nano? | |||
There was a problem hiding this comment.
Yeah this currently assumes np.diff(_times) and _halflife are both ns, so I think as long as they are both brought to the higher of the resolution it should be fine
|
#48961 (green except for the usual timeout) should cut a lot off the diff here |
mroeschke
approved these changes
Oct 7, 2022
|
Thanks @jbrockmendel. If #48910 (comment) needs addressing in the future that would be great |
noatamir
pushed a commit
to noatamir/pandas
that referenced
this pull request
Nov 9, 2022
* BUG: Timedelta.__new__ * remove assertion * GH refs * API: Timedelta(td64_obj) retain resolution * revert extraneous * remove debugging variable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some overlap with #48901, #48889