BUG: loc casting to object for multi block case when setting with list indexer #49161
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phofl
added
the
Indexing
pandas/core/indexing.py
Outdated
| # setting with a list, re-coerces | ||
| self._setitem_single_column(loc, value[:, i].tolist(), pi) | ||
| value_col = value[:, i] | ||
| if is_object_dtype(value_col): |
There was a problem hiding this comment.
nitpick value_col -> value_col.dtype
| @@ -1898,16 +1898,20 @@ def _setitem_with_indexer_2d_value(self, indexer, value): | |||
|
|
|||
| ilocs = self._ensure_iterable_column_indexer(indexer[1]) | |||
|
|
|||
| # GH#7551 Note that this coerces the dtype if we are mixed | |||
There was a problem hiding this comment.
is the GH reference here worth keeping somewhere?
There was a problem hiding this comment.
Don't think so, since we are avoiding this now
pandas/core/indexing.py
Outdated
| self._setitem_single_column(loc, value[:, i].tolist(), pi) | ||
| value_col = value[:, i] | ||
| if is_object_dtype(value_col): | ||
| # try coerce values as good as possible |
There was a problem hiding this comment.
the wording here is pretty kludgy, maybe "casting to list so that we do type inference in setitem_single_column"
mroeschke
approved these changes
Oct 18, 2022
|
Thanks @phofl |
noatamir
pushed a commit
to noatamir/pandas
that referenced
this pull request
Nov 9, 2022
…t indexer (pandas-dev#49161) * BUG: loc casting to object for multi block case when setting with list indexer * Remove xpasses * Fix windows * Adress comments * Remove condition
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.