-
-
Notifications
You must be signed in to change notification settings - Fork 18.5k
read_json engine keyword and pyarrow integration #49249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 19 commits
6aa72ca
c248b84
91b81cf
9020663
0388c4e
6911791
5ecd3e0
c660395
54570ca
eb709e7
0a9c841
7eccd83
986d8cb
b4409bb
0467fe8
569ab9b
4dc9adc
38bc7db
bed15df
a29e96a
cdfd747
c70c0b4
fe2b3ef
228ca64
d1acc94
0885f07
ab7af44
c9cde9e
8c96553
9cbf598
c59310b
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -7,3 +7,31 @@ def orient(request): | |
Fixture for orients excluding the table format. | ||
""" | ||
return request.param | ||
|
||
|
||
@pytest.fixture | ||
def json_dir_path(datapath): | ||
""" | ||
The directory path to the data files needed for parser tests. | ||
""" | ||
return datapath("io", "json", "data") | ||
|
||
|
||
@pytest.fixture(params=["ujson", "pyarrow"]) | ||
def engine(request): | ||
if request.param == "pyarrow": | ||
pytest.importorskip("pyarrow.json") | ||
return request.param | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Nit: Instead of the else, could you do
|
||
else: | ||
return request.param | ||
|
||
|
||
@pytest.fixture | ||
def json_engine_pyarrow_xfail(request): | ||
""" | ||
Fixture that xfails a test if the engine is pyarrow. | ||
""" | ||
engine = request.getfixturevalue("engine") | ||
if engine == "pyarrow": | ||
mark = pytest.mark.xfail(reason="pyarrow doesn't support this.") | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yeah I would prefer this to be added to each xfailed test so the There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @mroeschke I added a comment to each xfailed test. Is there another special way to do it? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
|
||
request.node.add_marker(mark) |
Uh oh!
There was an error while loading. Please reload this page.