Skip to content

DOC: Clarify deprecation of freq for Timestamp #49501

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

bashtage
Copy link
Contributor

@bashtage bashtage commented Nov 3, 2022

  • All code checks passed.
  • Added type annotations to new arguments/methods/functions.
  • Added an entry in the latest doc/source/whatsnew/vX.X.X.rst file if fixing a bug or adding a new feature.

@bashtage
Copy link
Contributor Author

bashtage commented Nov 3, 2022

The failure is wrong. Very strange, but both of these are clearly used.

@jbrockmendel
Copy link
Member

This seems benign, but will be moot once #49365 is merged

@bashtage
Copy link
Contributor Author

bashtage commented Nov 3, 2022

Should it go in for 1.5.x?

@jbrockmendel
Copy link
Member

Should it go in for 1.5.x?

sounds good

@mroeschke mroeschke added Docs Timestamp pd.Timestamp and associated methods labels Nov 3, 2022
@phofl
Copy link
Member

phofl commented Nov 16, 2022

Needs a rebase and ci is failing

@github-actions
Copy link
Contributor

This pull request is stale because it has been open for thirty days with no activity. Please update and respond to this comment if you're still interested in working on this.

@github-actions github-actions bot added the Stale label Dec 17, 2022
@mroeschke
Copy link
Member

Thanks for the pull request, but it appears to have gone stale. If interested in continuing, please merge in the main branch, address any review comments and/or failing tests, and we can reopen.

@mroeschke mroeschke closed this Dec 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Docs Stale Timestamp pd.Timestamp and associated methods
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants