Skip to content

WARN fixup warning in pandas/tests/apply/test_frame_apply.py #50299

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 16, 2022
Merged

WARN fixup warning in pandas/tests/apply/test_frame_apply.py #50299

merged 1 commit into from
Dec 16, 2022

Conversation

tpackard1
Copy link
Contributor

@tpackard1 tpackard1 commented Dec 16, 2022 •
edited
Loading

@MarcoGorelli
Copy link
Member

MarcoGorelli commented Dec 16, 2022 •
edited
Loading

you've got irrelevant commits here, can you do

git fetch upstream
git rebase -i upstream/main

then, in the pop-up, only select the last commit. then

git push origin HEAD --force

@tpackard1
Copy link
Contributor Author

Thanks I was wondering why all the other commits were showing up.

MarcoGorelli
MarcoGorelli reviewed Dec 16, 2022
View reviewed changes
doc/source/whatsnew/v0.19.0.rst Outdated
@@ -654,7 +654,7 @@ Comparison operators raise ``ValueError`` when ``.index`` are different.

In [3]: df1 == df2
Out[3]:
ValueError: Can only compare identically-labeled DataFrame objects
ValueError: Can only compare identically-labeled (both index and columns) DataFrame objects
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

still got an irrelevant change here

MarcoGorelli
MarcoGorelli approved these changes Dec 16, 2022
View reviewed changes
Copy link
Member

@MarcoGorelli MarcoGorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me pending green

@MarcoGorelli MarcoGorelli added the Warnings Warnings that appear or should be added to pandas label Dec 16, 2022
@MarcoGorelli MarcoGorelli added this to the 2.0 milestone Dec 16, 2022
@MarcoGorelli MarcoGorelli merged commit 060eaac into pandas-dev:main Dec 16, 2022
@tpackard1 tpackard1 deleted the test-frame-apply branch December 16, 2022 18:31
phofl pushed a commit to phofl/pandas that referenced this pull request Dec 17, 2022
@tpackard1 @phofl
WARN fixup warning in pandas/tests/apply/test_frame_apply.py (pandas-…
f1a65f1 
…dev#50299)

fix up warning in pandas/tests/apply/test_frame_apply.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarcoGorelli MarcoGorelli MarcoGorelli approved these changes

Assignees
No one assigned
Labels
Warnings Warnings that appear or should be added to pandas
Projects
None yet
Milestone
2.0
Development

Successfully merging this pull request may close these issues.

WARN fixup warning in pandas/tests/apply/test_frame_apply.py
2 participants
@tpackard1 @MarcoGorelli