TST: Test dtype sparseDtype with specificd fill value #50743
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phofl
reviewed
Jan 14, 2023
|
|
||
| def test_dtype_sparse_with_specified_fill_value(): | ||
| # GH 49987 | ||
| # specify fill_value which not present in data |
There was a problem hiding this comment.
Better to adjust the test name than to leave a comment
CI failures seem legit
There was a problem hiding this comment.
How about this one? Apparently I'm not very good at naming them.
phofl
reviewed
Jan 15, 2023
phofl
reviewed
Jan 15, 2023
phofl
approved these changes
Jan 16, 2023
phofl
added
Testing
|
thx @luke396 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fill_valuenot in series #49987 (Replace xxxx with the GitHub issue number)doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.