PERF: Fix performance regression in get_loc of IntervalIndex #51339
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phofl
added
Performance
pandas/core/arrays/interval.py
Outdated
| @@ -727,7 +730,7 @@ def __getitem__( | |||
| if np.ndim(left) > 1: | |||
| # GH#30588 multi-dimensional indexer disallowed | |||
| raise ValueError("multi-dimensional indexing not allowed") | |||
| return self._shallow_copy(left, right) | |||
| return self._shallow_copy(left, right, verify_integrity=False) | |||
There was a problem hiding this comment.
couldnt we also skip _ensure_simple_new_inputs, i.e. just do
return self._simple_new(left, right, dtype=self.dtype)
There was a problem hiding this comment.
let's see if it works, probably not necessary
pandas/core/arrays/interval.py
Outdated
| @@ -675,7 +677,8 @@ def _shallow_copy(self: IntervalArrayT, left, right) -> IntervalArrayT: | |||
| """ | |||
| dtype = IntervalDtype(left.dtype, closed=self.closed) | |||
| left, right, dtype = self._ensure_simple_new_inputs(left, right, dtype=dtype) | |||
| self._validate(left, right, dtype=dtype) | |||
| if verify_integrity: | |||
There was a problem hiding this comment.
so is this still necessary?
There was a problem hiding this comment.
Not for this regression, but I think we should look through all usages to see if it's necessary everywhere
|
pandas/core/arrays/interval.py:729: error: Argument 2 to "_simple_new" of "IntervalArray" has incompatible type "Union[Period, Timestamp, Timedelta, NaTType, DatetimeArray, TimedeltaArray, ndarray[Any, Any]]"; expected "Union[Union[DatetimeArray, TimedeltaArray], ndarray[Any, Any]]" [arg-type] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.caused in 184e1674
No need to call validate here
https://asv-runner.github.io/asv-collection/pandas/#indexing.IntervalIndexing.time_loc_list