REF: Refactor reference handling to the BlockManager level for iterrows #51431
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pandas/core/internals/managers.py
Outdated
| @@ -247,6 +247,16 @@ def _has_no_reference_block(self, blkno: int) -> bool: | |||
| """ | |||
| return not self.blocks[blkno].refs.has_reference() | |||
|
|
|||
| def add_references(self, mgr: BaseBlockManager) -> None: | |||
| """ | |||
| Adds the references from one manager to another. | |||
There was a problem hiding this comment.
This assumes an identical block structure between both managers?
There was a problem hiding this comment.
Yep, I’ll add a comment explaining this
jorisvandenbossche
changed the title
jorisvandenbossche
approved these changes
Feb 17, 2023
pandas/core/frame.py
Outdated
Comment on lines
1399
to
1400
| # Argument 1 to "add_references" of "BaseArrayManager" has incompatible | ||
| # type "Union[BlockManager, ArrayManager]"; expected "BaseArrayManager" |
There was a problem hiding this comment.
To be honest, this is kind of bullshit .. (and just noise to add as a comment) There is no easy way to let mypy understand such typing with a base class?
There was a problem hiding this comment.
Theoretically we could make mypy aware that using_copy_on_write() guards agains ArrayManager, but I am not that familiar with mypy :)
Removed.
|
Merging, this was only a removed comment |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.let's see if this passes everything