Skip to content

CLN: read_html global importing check #51505

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 21, 2023
Merged

CLN: read_html global importing check #51505

merged 2 commits into from
Feb 21, 2023

Conversation

mroeschke
Copy link
Member

This defers read_html library checking even more and avoids global variable gymnastics

@mroeschke mroeschke added the IO HTML read_html, to_html, Styler.apply, Styler.applymap label Feb 20, 2023
@mroeschke mroeschke added this to the 2.1 milestone Feb 21, 2023
phofl
phofl approved these changes Feb 21, 2023
View reviewed changes
Copy link
Member

@phofl phofl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice simplification

@phofl phofl merged commit 87fd0b5 into pandas-dev:main Feb 21, 2023
@phofl
Copy link
Member

phofl commented Feb 21, 2023

thx @mroeschke

@mroeschke mroeschke deleted the cln/html/imports branch February 21, 2023 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phofl phofl phofl approved these changes

Assignees
No one assigned
Labels
IO HTML read_html, to_html, Styler.apply, Styler.applymap
Projects
None yet
Milestone
2.1
Development

Successfully merging this pull request may close these issues.
2 participants
@mroeschke @phofl