Skip to content

WEB: Sort and fix link to under discussions PDEPs #51656

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 27, 2023

Conversation

datapythonista
Copy link
Member

The links to the under discussion PDEPs in https://pandas.pydata.org/about/roadmap.html point to the API page, not the html page, fixing. Also, sorting the list by title.

@datapythonista datapythonista added the Web pandas website label Feb 26, 2023
Copy link
Member

@phofl phofl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess sorting by title is better than the current status, but wouldn't this place PDEP-10 before PDEP-9?

@datapythonista
Copy link
Member Author

I guess sorting by title is better than the current status, but wouldn't this place PDEP-10 before PDEP-9?

Yes, you're correct. I realized when I finished implementing, but I didn't want to implement a more complex sorting using regex here, since this was originally to fix the links, and also we can consider other options like using PDEP-0001... (we're doing that with the file names). I'd personally merge this first, so the links are working, but happy to have the discussion here too.

Copy link
Member

@phofl phofl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

merging first sounds good, can you open an issue about the sorting?

@phofl phofl added this to the 2.1 milestone Feb 27, 2023
@phofl phofl merged commit 13f3824 into pandas-dev:main Feb 27, 2023
@phofl
Copy link
Member

phofl commented Feb 27, 2023

thx @datapythonista

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Web pandas website
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants