Skip to content

TST: add test for apply/reconstruct_func #51705

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Mar 3, 2023
Merged

TST: add test for apply/reconstruct_func #51705

merged 4 commits into from
Mar 3, 2023

Conversation

renatocmaciel
Copy link
Contributor

@renatocmaciel renatocmaciel commented Mar 1, 2023 •
edited
Loading

Add a test for reconstruct_func to ensure this method isn't moved. It is used by other libraries such as dask.

@renatocmaciel renatocmaciel marked this pull request as ready for review March 2, 2023 02:50
@rhshadrach rhshadrach added Apply Apply, Aggregate, Transform, Map Needs Tests Unit test(s) needed to prevent regressions Groupby labels Mar 3, 2023
@rhshadrach rhshadrach added this to the 2.1 milestone Mar 3, 2023
rhshadrach
rhshadrach approved these changes Mar 3, 2023
View reviewed changes
Copy link
Member

@rhshadrach rhshadrach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rhshadrach rhshadrach merged commit d9ba285 into pandas-dev:main Mar 3, 2023
@rhshadrach
Copy link
Member

Thanks @renatocmaciel!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rhshadrach rhshadrach rhshadrach approved these changes

Assignees
No one assigned
Labels
Apply Apply, Aggregate, Transform, Map Groupby Needs Tests Unit test(s) needed to prevent regressions
Projects
None yet
Milestone
2.1
Development

Successfully merging this pull request may close these issues.

_normalize_keyword_aggregation` named agg helper function should be made public
2 participants
@renatocmaciel @rhshadrach