-
-
Notifications
You must be signed in to change notification settings - Fork 18.5k
API / CoW: Copy NumPy arrays by default in DataFrame constructor #51731
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
jorisvandenbossche
merged 29 commits into
pandas-dev:main
from
phofl:cow_copy_numpy_array
Mar 17, 2023
Merged
Changes from 2 commits
Commits
Show all changes
29 commits
Select commit
Hold shift + click to select a range
563257e
Implement copy by default for numpy array
phofl f3161a3
Fix tests
phofl 3a95311
Simplify
phofl 17cf5ae
Fix
phofl 07aa26d
Remove
phofl 8e84d85
Merge branch 'main' into cow_copy_numpy_array
phofl f3ccf0f
Add comment
phofl 5cdc6ad
Fix
phofl 3e384ea
Change logic
phofl 49ee53f
Merge remote-tracking branch 'upstream/main' into cow_copy_numpy_array
phofl fcc7be2
Fix tests
phofl 9223836
Fix test
phofl a474bf5
Fix test
phofl d5a0268
Merge branch 'main' into cow_copy_numpy_array
phofl 0be7fc6
Merge remote-tracking branch 'upstream/main' into cow_copy_numpy_array
phofl 293f8a5
Remove order changes
phofl 3376d06
Merge remote-tracking branch 'upstream/main' into cow_copy_numpy_array
phofl 265d9e3
Update
phofl 9ac1bae
Address review
phofl db92ce4
Add test
phofl be9cb04
Fix test
phofl 4bf3ee8
Merge branch 'main' into cow_copy_numpy_array
phofl e2eceec
Fix array manager
phofl 65965c6
Remove elif
phofl ecb756c
Update pandas/tests/copy_view/test_constructors.py
phofl 8e837d9
Merge remote-tracking branch 'upstream/main' into cow_copy_numpy_array
phofl 177fbbc
Add whatsnew
phofl 2bbff3b
Merge branch 'main' into cow_copy_numpy_array
phofl 5bef4ba
Add note
phofl File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we add a warning like (about copy=False): "in that case pandas does not guarantee correct Copy-on-Write behaviour in case the numpy array would get modified after creating the DataFrame"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added