Skip to content

PERF/REF: make window/groupby imports lazy #51823

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 17 commits into from

Conversation

jbrockmendel
Copy link
Member

Maybe makes 20ms difference, hard to measure. But separating this out from other import-speed stuff bc the docstring movement makes the diff big.

@jbrockmendel
Copy link
Member Author

Restored groupby imports in core.api bc i think dask accesses pd.core.groupby.GroupBy. Restoring that basically undoes the perf improvement, so this is just a refactor at this point

@jbrockmendel jbrockmendel deleted the perf-import-window branch April 19, 2023 20:35
@jbrockmendel jbrockmendel mentioned this pull request Apr 21, 2023
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant