Skip to content

BUG: Corrected TypeError message #52074

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Mar 20, 2023
Merged

BUG: Corrected TypeError message #52074

merged 6 commits into from
Mar 20, 2023

Conversation

DeaMariaLeon
Copy link
Member

@DeaMariaLeon DeaMariaLeon added Error Reporting Incorrect or improved errors from pandas Timezones Timezone data dtype labels Mar 19, 2023
phofl
phofl reviewed Mar 19, 2023
View reviewed changes
Copy link
Member

@phofl phofl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a test checking the error message?

@DeaMariaLeon
Copy link
Member Author

Sure @phofl but where??? at pandas/tests/indexes/datetimes/test_datetime.py ?
or
pandas/tests/indexes/datetimes/test_indexing.py maybe?

Thanks in advance

@phofl
Copy link
Member

phofl commented Mar 20, 2023

I'd suggest

pandas/tests/indexes/datetimes/test_constructors.py

@DeaMariaLeon
Copy link
Member Author

Done

@phofl phofl added this to the 2.1 milestone Mar 20, 2023
@phofl phofl merged commit 900ffa3 into pandas-dev:main Mar 20, 2023
@phofl
Copy link
Member

phofl commented Mar 20, 2023

thx @DeaMariaLeon

@DeaMariaLeon DeaMariaLeon deleted the time branch March 21, 2023 14:10
@DeaMariaLeon
Copy link
Member Author

Thank you @phofl

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phofl phofl phofl approved these changes

Assignees
No one assigned
Labels
Error Reporting Incorrect or improved errors from pandas Timezones Timezone data dtype
Projects
None yet
Milestone
2.1
Development

Successfully merging this pull request may close these issues.

BUG: DatetimeIndex() constructor with mixed timezones gives confusing TypeError
2 participants
@DeaMariaLeon @phofl