Skip to content

BUG: to_numeric converting StringArray to object or float64 #52174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 24, 2023

Conversation

phofl
Copy link
Member

@phofl phofl commented Mar 24, 2023

don't need a whatsnew if we get it in for 2.0

@phofl phofl added the Dtype Conversions Unexpected or buggy dtype conversions label Mar 24, 2023
@phofl phofl added this to the 2.0 milestone Mar 24, 2023
@phofl phofl requested a review from mroeschke March 24, 2023 18:58
@mroeschke mroeschke merged commit e785998 into pandas-dev:main Mar 24, 2023
@mroeschke
Copy link
Member

Thanks @phofl

@lumberbot-app
Copy link

lumberbot-app bot commented Mar 24, 2023

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

  1. Checkout backport branch and update it.
git checkout 2.0.x
git pull
  1. Cherry pick the first parent branch of the this PR on top of the older branch:
git cherry-pick -x -m1 e7859983a814b1823cf26e3b491ae2fa3be47c53
  1. You will likely have some merge/cherry-pick conflict here, fix them and commit:
git commit -am 'Backport PR #52174: BUG: to_numeric converting StringArray to object or float64'
  1. Push to a named branch:
git push YOURFORK 2.0.x:auto-backport-of-pr-52174-on-2.0.x
  1. Create a PR against branch 2.0.x, I would have named this PR:

"Backport PR #52174 on branch 2.0.x (BUG: to_numeric converting StringArray to object or float64)"

And apply the correct labels and milestones.

Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon!

Remember to remove the Still Needs Manual Backport label once the PR gets merged.

If these instructions are inaccurate, feel free to suggest an improvement.

@phofl phofl deleted the 52146 branch March 24, 2023 23:49
phofl added a commit to phofl/pandas that referenced this pull request Mar 25, 2023
…ev#52174)

* BUG: to_numeric converting StringArray to object or float64

* BUG: to_numeric converting StringArray to object or float64

* Update comment
phofl added a commit to phofl/pandas that referenced this pull request Mar 25, 2023
…ev#52174)

* BUG: to_numeric converting StringArray to object or float64

* BUG: to_numeric converting StringArray to object or float64

* Update comment
phofl added a commit that referenced this pull request Mar 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dtype Conversions Unexpected or buggy dtype conversions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: to_numeric does not return Arrow backed data for StringDtype("pyarrow")
2 participants