PERF: avoid is_datetime64_any_dtype #52651
Conversation
doc/source/whatsnew/v2.1.0.rst
Outdated
| @@ -234,6 +234,7 @@ Deprecations | |||
| - Deprecated :func:`is_datetime64tz_dtype`, check ``isinstance(dtype, pd.DatetimeTZDtype)`` instead (:issue:`52607`) | |||
| - Deprecated unused "closed" and "normalize" keywords in the :class:`DatetimeIndex` constructor (:issue:`52628`) | |||
| - Deprecated unused "closed" keyword in the :class:`TimedeltaIndex` constructor (:issue:`52628`) | |||
| - Deprecated :func:`is_datetime64_any_dtype`, check for specific dtypes of interest instead (:issue:`52651`) | |||
There was a problem hiding this comment.
Is there a way to keep utility functions that are more complicated to reimplement? A single is instance check is fine, but more complicated things would cause duplication for users.
There was a problem hiding this comment.
i guess. all i really care about is that we dont use this internally. but i do think its a footgun since pretty much anyone who uses it wrote it with only numpy/pd.DatetimeTZDtype in mind
jbrockmendel
changed the title
jbrockmendel
added
Performance
|
reverted deprecation, so this is just avoiding internal usages |
pandas/core/dtypes/common.py
Outdated
| @@ -1219,7 +1219,18 @@ def is_bool_dtype(arr_or_dtype) -> bool: | |||
|
|
|||
| if isinstance(arr_or_dtype, ABCIndex): | |||
| # Allow Index[object] that is all-bools or Index["boolean"] | |||
| return arr_or_dtype.inferred_type == "boolean" | |||
| if arr_or_dtype.inferred_type == "boolean": | |||
There was a problem hiding this comment.
Hmm this looks unrelated. Did a merge conflict go wrong in this PR?
There was a problem hiding this comment.
agreed, will revert
pandas/core/dtypes/common.py
Outdated
| @@ -1219,18 +1219,7 @@ def is_bool_dtype(arr_or_dtype) -> bool: | |||
|
|
|||
| if isinstance(arr_or_dtype, ABCIndex): | |||
| # Allow Index[object] that is all-bools or Index["boolean"] | |||
| if arr_or_dtype.inferred_type == "boolean": | |||
There was a problem hiding this comment.
Hmm I thought we wanted to still deprecate this in 2.1?
There was a problem hiding this comment.
un-reverted + green
|
Thanks @jbrockmendel |
This was written with numpy dtypes and DatetimeTZDtype in mind, but will now catch 3rd party and ArrowDtype[timestamp] too, so will be a footgun.