Skip to content

add: literal type hints for methods in NDFrame #52724

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 19, 2023
Merged

add: literal type hints for methods in NDFrame #52724

merged 2 commits into from
Apr 19, 2023

Conversation

YYYasin19
Copy link
Contributor

  • closes #xxxx (Replace xxxx with the GitHub issue number)
  • Tests added and passed if fixing a bug or adding a new feature
  • All code checks passed.
  • Added type annotations to new arguments/methods/functions.
  • Added an entry in the latest doc/source/whatsnew/vX.X.X.rst file if fixing a bug or adding a new feature.

@YYYasin19 YYYasin19 changed the title add: literal type hints add: literal type hints for methods in NDFrame Apr 18, 2023
@noatamir noatamir added the Sprints Sprint Pull Requests label Apr 18, 2023
twoertwein
twoertwein reviewed Apr 19, 2023
View reviewed changes
twoertwein
twoertwein reviewed Apr 19, 2023
View reviewed changes
@mroeschke mroeschke added this to the 2.1 milestone Apr 19, 2023
@mroeschke mroeschke merged commit bf698e2 into pandas-dev:main Apr 19, 2023
@mroeschke
Copy link
Member

Thanks @YYYasin19

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@twoertwein twoertwein twoertwein approved these changes

@mroeschke mroeschke mroeschke approved these changes

Assignees
No one assigned
Labels
Sprints Sprint Pull Requests
Projects
None yet
Milestone
2.1
Development

Successfully merging this pull request may close these issues.
4 participants
@YYYasin19 @mroeschke @twoertwein @noatamir