Skip to content

Added tests for period str and repr. #53003

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

smarie
Copy link
Contributor

@smarie smarie commented Apr 29, 2023

@smarie
Copy link
Contributor Author

smarie commented Apr 29, 2023

All set - Ready for review @MarcoGorelli !

@MarcoGorelli MarcoGorelli self-requested a review April 30, 2023 09:10
@mroeschke mroeschke added Testing pandas testing functions or related to the test suite Period Period data type labels May 1, 2023
Copy link
Member

@MarcoGorelli MarcoGorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @smarie , nice one!

@MarcoGorelli MarcoGorelli added this to the 2.1 milestone May 5, 2023
@MarcoGorelli MarcoGorelli added Needs Tests Unit test(s) needed to prevent regressions and removed Testing pandas testing functions or related to the test suite labels May 5, 2023
@MarcoGorelli MarcoGorelli merged commit fe70255 into pandas-dev:main May 5, 2023
@smarie
Copy link
Contributor Author

smarie commented May 6, 2023

Thanks @MarcoGorelli for the quick review ! We can now proceed with #51459 , I updated the PR.

@smarie smarie deleted the feature/53000_more_tests_for_period_repr branch May 6, 2023 13:18
topper-123 pushed a commit to topper-123/pandas that referenced this pull request May 7, 2023
* Added tests for period str and repr. Fixes pandas-dev#53000

* Removed commented params in test, improved test for repr, and blackened.

* Better tests

* Moved the two independent tests into parametrized test

---------

Co-authored-by: Sylvain MARIE <[email protected]>
Rylie-W pushed a commit to Rylie-W/pandas that referenced this pull request May 19, 2023
* Added tests for period str and repr. Fixes pandas-dev#53000

* Removed commented params in test, improved test for repr, and blackened.

* Better tests

* Moved the two independent tests into parametrized test

---------

Co-authored-by: Sylvain MARIE <[email protected]>
Daquisu pushed a commit to Daquisu/pandas that referenced this pull request Jul 8, 2023
* Added tests for period str and repr. Fixes pandas-dev#53000

* Removed commented params in test, improved test for repr, and blackened.

* Better tests

* Moved the two independent tests into parametrized test

---------

Co-authored-by: Sylvain MARIE <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Tests Unit test(s) needed to prevent regressions Period Period data type
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TST: Add tests for repr(pd.Period)
3 participants