-
-
Notifications
You must be signed in to change notification settings - Fork 18.6k
BUG: fix datetimeindex repr #53634
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
BUG: fix datetimeindex repr #53634
Changes from all commits
Commits
Show all changes
40 commits
Select commit
Hold shift + click to select a range
c0e59e7
add bug fix for datetimeindex repr
Simar-B 642ee78
Add tests
Simar-B dcd565e
Run precommit
Simar-B 6a8551e
Add bug fix to docs
Simar-B 8fac63d
Merge branch 'main' into bug-fix-datetimeindex
Simar-B ba877ba
Merge branch 'main' into bug-fix-datetimeindex
Simar-B 39b93e0
Add check for delta
Simar-B 2b6cd5e
Merge branch 'bug-fix-datetimeindex' of github.com:Simar-B/pandas int…
Simar-B 09303b2
Fix check for delta
Simar-B 4d1506a
Fix precheck
Simar-B b1c0cf6
Fix union-attrs mypy check
Simar-B 8cc72fd
Merge branch 'main' into bug-fix-datetimeindex
Simar-B 43ac7b8
Address Pr comments
Simar-B 593e28c
Reset test_datetime.py
Simar-B 234bebb
Merge branch 'main' into bug-fix-datetimeindex
Simar-B 2b862ea
Fix precommit
Simar-B 86b2fe0
Merge branch 'bug-fix-datetimeindex' of github.com:Simar-B/pandas int…
Simar-B c22f7e7
Fix precommit quotes
Simar-B d12977a
Fix formatting
Simar-B 6e651eb
Merge branch 'main' into bug-fix-datetimeindex
Simar-B e6ef416
Fix whatsnew doc
Simar-B 0896cc9
Update tests to assert
Simar-B 95a4a5a
run precommit
Simar-B 7d78db5
Merge branch 'main' into bug-fix-datetimeindex
Simar-B 7cc38c2
break up long line
Simar-B b2ac29d
Merge branch 'bug-fix-datetimeindex' of github.com:Simar-B/pandas int…
Simar-B 56c5b16
Fix space placement
Simar-B 76e0138
Merge branch 'main' into bug-fix-datetimeindex
Simar-B ad6189f
Merge branch 'main' into bug-fix-datetimeindex
Simar-B 9dc91ec
Merge branch 'main' into bug-fix-datetimeindex
Simar-B 41becc0
Merge branch 'main' into bug-fix-datetimeindex
Simar-B 3f7adc6
Add github issue number
Simar-B 8e685b5
Merge branch 'bug-fix-datetimeindex' of github.com:Simar-B/pandas int…
Simar-B 423036f
use datetime timedelta
Simar-B f89920b
run precommit
Simar-B 208d2a9
Merge branch 'main' into bug-fix-datetimeindex
Simar-B de007da
Merge branch 'main' into bug-fix-datetimeindex
Simar-B dfc26c0
Merge branch 'main' into bug-fix-datetimeindex
Simar-B 64ddebd
Fix formatting
Simar-B a9d1698
Use getattr
Simar-B File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There seem to be no tests for non-daily and non-hourly freq values. I provided a more comprehensive set of tests in Simar-B#1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unfortunately right now it is impossible to differentiate a
DatetimeIndex
where time has been passed vs when time has not been passed (see here). Therefore, nothing more can be done afaik.