Skip to content

TYP: reshape.merge #53752

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 21, 2023
Merged

TYP: reshape.merge #53752

merged 1 commit into from
Jun 21, 2023

Conversation

jbrockmendel
Copy link
Member

  • closes #xxxx (Replace xxxx with the GitHub issue number)
  • Tests added and passed if fixing a bug or adding a new feature
  • All code checks passed.
  • Added type annotations to new arguments/methods/functions.
  • Added an entry in the latest doc/source/whatsnew/vX.X.X.rst file if fixing a bug or adding a new feature.

@jbrockmendel jbrockmendel requested a review from rhshadrach as a code owner June 20, 2023 21:31
@mroeschke mroeschke added Typing type annotations, mypy/pyright type checking Reshaping Concat, Merge/Join, Stack/Unstack, Explode labels Jun 21, 2023
@mroeschke mroeschke added this to the 2.1 milestone Jun 21, 2023
@mroeschke mroeschke merged commit 78fac35 into pandas-dev:main Jun 21, 2023
@mroeschke
Copy link
Member

Thanks @jbrockmendel

rhshadrach
rhshadrach approved these changes Jun 21, 2023
View reviewed changes
Copy link
Member

@rhshadrach rhshadrach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rhshadrach
Copy link
Member

Hah! Guess I was too slow..

@jbrockmendel jbrockmendel deleted the ref-get_join_indexers branch June 21, 2023 01:27
Daquisu pushed a commit to Daquisu/pandas that referenced this pull request Jul 8, 2023
@jbrockmendel
TYP: reshape.merge (pandas-dev#53752)
0d53574
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mroeschke mroeschke mroeschke approved these changes

@rhshadrach rhshadrach rhshadrach approved these changes

Assignees
No one assigned
Labels
Reshaping Concat, Merge/Join, Stack/Unstack, Explode Typing type annotations, mypy/pyright type checking
Projects
None yet
Milestone
2.1
Development

Successfully merging this pull request may close these issues.
3 participants
@jbrockmendel @mroeschke @rhshadrach