Skip to content

DOC/BUG: fix details for 'quoting' parser parameter #5408

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 21, 2014
Merged

DOC/BUG: fix details for 'quoting' parser parameter #5408

merged 1 commit into from
Jan 21, 2014

Conversation

patricktokeeffe
Copy link
Contributor 

Python 2.7.5 (default, May 15 2013, 22:44:16) [MSC v.1500 64 bit (AMD64)] on win32
Type "help", "copyright", "credits" or "license" for more information.

Imported NumPy 1.7.1, SciPy 0.12.0, Matplotlib 1.3.0 + guidata 1.6.1, guiqwt 2.3.1
Type "scientific" for more details.
>>> from csv import QUOTE_MINIMAL, QUOTE_ALL, QUOTE_NONNUMERIC, QUOTE_NONE
>>> QUOTE_MINIMAL
0
>>> QUOTE_ALL
1
>>> QUOTE_NONNUMERIC
2
>>> QUOTE_NONE
3
>>>

jtratner
jtratner reviewed Nov 1, 2013
View reviewed changes
pandas/io/parsers.py
@@ -41,7 +41,7 @@
quoting : int
Controls whether quotes should be recognized. Values are taken from
`csv.QUOTE_*` values. Acceptable values are 0, 1, 2, and 3 for
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how about instead we remove the actual numbers and only suggest you pass the enum-likes? Needlessly complicated otherwise, no?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not opposed. It took a little while to even determine these were swapped.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do it! :)

@patricktokeeffe
Copy link
Contributor Author

How's it look now?

@jreback
Copy link
Contributor

jreback commented Nov 5, 2013

can you squash this down to a single commit?

@patricktokeeffe
Copy link
Contributor Author

Yeah, sure. Will I need to rebase on master too?

@jreback
Copy link
Contributor

jreback commented Dec 5, 2013

does this close an issue?

@jreback
Copy link
Contributor

jreback commented Jan 3, 2014

pls rebase this and can consider for 0.13.1

jorisvandenbossche
jorisvandenbossche reviewed Jan 4, 2014
View reviewed changes
pandas/io/parsers.py
Controls whether quotes should be recognized. Values are taken from
`csv.QUOTE_*` values. Acceptable values are 0, 1, 2, and 3 for
QUOTE_MINIMAL, QUOTE_ALL, QUOTE_NONE, and QUOTE_NONNUMERIC, respectively.
The character to used to denote the start and end of a quoted item.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'to used to' -> 'used to'

@jreback
Copy link
Contributor

jreback commented Jan 17, 2014

@patricktokeeffe can you rebase and make that small change?

@patricktokeeffe
Copy link
Contributor Author

OK @jreback I think I've finally succeeded without mucking up the repo. Let me know if it needs anything else.

@jreback
Copy link
Contributor

jreback commented Jan 20, 2014

@jorisvandenbossche ok on formatting?

@patricktokeeffe
Copy link
Contributor Author

Just realized the issue # was missing from the commit log. It's been added & rebased over the last few commits.

@jorisvandenbossche
Copy link
Member

OK!

jreback added a commit that referenced this pull request Jan 21, 2014
@jreback
Merge pull request #5408 from patricktokeeffe/fix-parser-docstring
cabe9b1 
DOC/BUG: fix details for 'quoting' parser parameter
@jreback jreback merged commit cabe9b1 into pandas-dev:master Jan 21, 2014
@jreback
Copy link
Contributor

jreback commented Jan 21, 2014

thanks

@patricktokeeffe patricktokeeffe deleted the fix-parser-docstring branch January 22, 2014 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.13.1
Development

Successfully merging this pull request may close these issues.
4 participants
@patricktokeeffe @jreback @jorisvandenbossche @jtratner