CoW: Copy less in replace implementation with listlikes #54116
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
General concern: do we think this is worth the added complexity? (and the replace code is already really complex ..) The case it is trying to solve is that if you do an inplace replace with a list like, this could be done actually inplace (if there are no other refs to start with), while now it always makes a copy? |
|
This is generally for listlike replace ops, not only inplace. The current implementation copies for every pass, which is too slow imo |
And does that only happen under CoW, or also in the default? |
|
Both as far as I know, but we should fix this anyway |
# Conflicts: # pandas/core/internals/blocks.py # pandas/tests/copy_view/test_replace.py
|
Also agreed to merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.This is the best version I could come up with