-
-
Notifications
You must be signed in to change notification settings - Fork 18.6k
TST: Improved test coverage for Styler.bar error conditions #56341
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
0962c4a
Improved test coverage for Styler.bar error conditions
ccccjone 14e7b59
Fixed the code style issue causing test failure
ccccjone e918b1c
Fixed a Styler.bar bug of missing value
ccccjone fdce172
Adopted another tricky way to fix the bug
ccccjone 33e6035
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 13e976a
Added a test for Styler.bar with pyarrow
ccccjone dc77342
Updated with code style
ccccjone 32e1cca
Merge remote-tracking branch 'upstream/main' into enhence_Styler_bar_…
ccccjone a70a80a
Merge remote-tracking branch 'upstream/main' into enhence_Styler_bar_…
ccccjone 039fa2d
Merge remote-tracking branch 'upstream/main' into enhence_Styler_bar_…
ccccjone File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you test arrow types here per the original issue?
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @mroeschke , thank you for your response. I tried to add
pyarrow
into the test like the origin issue, but encountered a DeprecationWarning when usingengine="pyarrow"
.I noticed two PRs related to
pyarrow
issue, #55637 and #55576 , where several tests were marked as xfail due to parsing or type problems withpyarrow
.However, the test can be passed without specifying the engine, and I updated this test in my recent commit, although
pyarrow
maybe not suitable for this unit test.Look forward to your advice. Thank you!