CoW: Boolean indexer in MultiIndex raising read-only error #56635
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phofl
added
Blocker
phofl
commented
Dec 27, 2023
pandas/core/indexes/multi.py
Outdated
| @@ -3487,7 +3487,7 @@ def _to_bool_indexer(indexer) -> npt.NDArray[np.bool_]: | |||
| "cannot index with a boolean indexer that " | |||
| "is not the same length as the index" | |||
| ) | |||
| lvl_indexer = np.asarray(k) | |||
| lvl_indexer = np.asarray(k).copy() | |||
There was a problem hiding this comment.
Not copying here propagates all the way to the input mask
phofl
added
the
Indexing
mroeschke
approved these changes
Dec 28, 2023
|
Thanks @phofl |
meeseeksmachine
pushed a commit
to meeseeksmachine/pandas
that referenced
this pull request
Dec 28, 2023
…ing read-only error
mroeschke
pushed a commit
that referenced
this pull request
Dec 28, 2023
…x raising read-only error) (#56660) Backport PR #56635: CoW: Boolean indexer in MultiIndex raising read-only error Co-authored-by: Patrick Hoefler <[email protected]>
cbpygit
pushed a commit
to cbpygit/pandas
that referenced
this pull request
Jan 2, 2024
…v#56635) * CoW: Boolean indexer in MultiIndex raising read-only error * Fixup * Add whatsnew
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found this while going through the docs