-
-
Notifications
You must be signed in to change notification settings - Fork 18.5k
TST: assert that informative error is raised when offset not supported as a period frequency is passed to DataFrame.asfreq #56758
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
MarcoGorelli
merged 9 commits into
pandas-dev:main
from
aram-cedarwood:raise_TypeError_for_unsupported_freq_in_asfreq
Feb 12, 2024
Merged
Changes from 2 commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
39b01ce
style
aram-cedarwood 1d4dee9
add test
aram-cedarwood 3c80b2d
pytest.raises
aram-cedarwood a1174ac
freqstr
aram-cedarwood ad6f0e3
add test for offsets
aram-cedarwood a606d55
rearrange per comment
aram-cedarwood 47b6af6
Merge remote-tracking branch 'upstream/main' into raise_TypeError_for…
MarcoGorelli 721d152
fixup
MarcoGorelli 52982ec
fixup
MarcoGorelli File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -8,6 +8,7 @@ | |
from pandas import ( | ||
DataFrame, | ||
DatetimeIndex, | ||
PeriodIndex, | ||
Series, | ||
date_range, | ||
period_range, | ||
|
@@ -257,3 +258,12 @@ def test_asfreq_frequency_M_Q_Y_A_deprecated(self, freq, freq_depr): | |
with tm.assert_produces_warning(FutureWarning, match=depr_msg): | ||
result = df.asfreq(freq=freq_depr) | ||
tm.assert_frame_equal(result, expected) | ||
|
||
def test_asfreq_unsupported_freq(self): | ||
index = PeriodIndex(["2020-01-01", "2021-01-01"], freq="M") | ||
df = DataFrame({"a": Series([0, 1], index=index)}) | ||
|
||
try: | ||
aram-cedarwood marked this conversation as resolved.
Show resolved
Hide resolved
|
||
df.asfreq(freq="2MS") | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Can you parametrize over a BaseOffset and the freq given as a string? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. sure, although this PR isn't really about the offset cases |
||
except TypeError as err: | ||
assert '"2MS" is not supported as a period frequency' == str(err) |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.