Support large strings in interchange protocol #56772
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarcoGorelli
suggested changes
Jan 8, 2024
There was a problem hiding this comment.
Thanks for working on this!
If I run
df = pd.Series([], name="a", dtype="large_string[pyarrow]").to_frame()
dfi = df.__dataframe__()
result = pd.api.interchange.from_dataframe(dfi)
print(dfi.__dataframe__().get_column_by_name('a').get_buffers()['data'])then I get
(PandasBuffer({'bufsize': 0, 'ptr': 94739763740952, 'device': 'CPU'}), (<DtypeKind.STRING: 21>, 8, 'u', '='))
I think it should be 'U' at the end?
I think you just need to update
pandas/pandas/core/interchange/column.py
Lines 303 to 309 in d2f05c2
|
That may also fix #56754 |
|
@MarcoGorelli Does your commit fix the issue you detected earlier? If yes, we could backport to 2.2 |
3 tasks
meeseeksmachine
pushed a commit
to meeseeksmachine/pandas
that referenced
this pull request
Jan 9, 2024
|
Thanks to you :) |
MarcoGorelli
pushed a commit
that referenced
this pull request
Jan 9, 2024
…nge protocol) (#56795) Backport PR #56772: Support large strings in interchange protocol Co-authored-by: Patrick Hoefler <[email protected]>
pmhatre1
pushed a commit
to pmhatre1/pandas-pmhatre1
that referenced
this pull request
May 7, 2024
* Support large strings in interchange protocol * Update test_impl.py * fixup buffer dtype, add todo * add whatsnew --------- Co-authored-by: MarcoGorelli <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.cc @MarcoGorelli