Skip to content

raise error on unsafe decimal parse with pyarrow types #56985

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jan 23, 2024

Conversation

rohanjain101
Copy link
Contributor

@WillAyd WillAyd added the Arrow pyarrow functionality label Jan 21, 2024
Copy link
Member

@WillAyd WillAyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm - @mroeschke

@mroeschke mroeschke added this to the 3.0 milestone Jan 23, 2024
@mroeschke mroeschke merged commit c3fc9bb into pandas-dev:main Jan 23, 2024
@mroeschke
Copy link
Member

Thanks @rohanjain101

@rohanjain101 rohanjain101 deleted the decimal_parse branch January 23, 2024 16:29
pmhatre1 pushed a commit to pmhatre1/pandas-pmhatre1 that referenced this pull request May 7, 2024
)

* raise error on unsafe decimal parse with pyarrow types

* fix min versions

* restore typeerrro

* success

---------

Co-authored-by: Rohan Jain <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Arrow pyarrow functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: Unsafe decimal parse for arrow types silently truncates value instead of raising an error
3 participants